search

conda-forge / llvmdev-feedstock

A conda-smithy repository for llvmdev.
BSD 3-Clause "New" or "Revised" License
8 stars 41 forks source link

add entry-point for llvm-lit #210

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

By default, LLVM's CMake files will look for llvm-lit. Add this entry-point to make life easier for consuming feedstocks (i.e. without manually having to set LLVM_EXTERNAL_LIT).

The existing lit entrypoint here was set in https://github.com/conda-forge/llvmdev-feedstock/pull/67, not sure what rationale went into the naming at the time (matches pip import, though no discussion in the PR); in any case I think it would be fine to keep both.

PTAL @isuruf

CC @hmaarrfk

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 1 year ago

The existing lit entrypoint here was set in https://github.com/conda-forge/llvmdev-feedstock/pull/67, not sure what rationale went into the naming at the time (matches pip import, though no discussion in the PR); in any case I think it would be fine to keep both.

Did you check the setup.py file?

h-vetinari commented 1 year ago

Did you check the setup.py file?

Nope (now I did), because I didn't doubt that the choice of lit made sense.

It seems that LLVM itself is inconsistent (I might raise an issue if we think it's worth it), but in the meantime I think it'd be better to have both entry points, no?

isuruf commented 1 year ago

Yes, but please make your comment better.

h-vetinari commented 1 year ago

Can you check if the comment is OK now? If so, I'm also planning to backport this to 15.x.

h-vetinari commented 1 year ago

Looks good, but tests seem to time out now

This happens somewhat regularly when the osx agent is slow. I doubt that an additional entry point will lengthen the build in any substantial way. Thanks for restarting!