Closed seanyen closed 5 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
@alexbw this is ready for review and merge. thanks!
cc @jakirkham @blowekamp
It's be great to use this in my SimpleITK package. I have done something very similar here: https://github.com/SimpleITK/SimpleITK/blob/master/SuperBuild/lua.cmake
Can you also add the license_file entry?
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Can you also add the license_file entry?
Sure, btw Lua
doesn't place a LICENCE
file by convention, but it bakes it in doc/readme.html
. That's why I pointed the license_file
there.
@isuruf The test & build is passed, and it is ready to merge. Thanks!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)seanyen
as a co-maintainer.