Enable Windows build - Githubissues

conda-forge / lua-feedstock

A conda-smithy repository for lua.

BSD 3-Clause "New" or "Revised" License

3 stars 16 forks source link

Closed seanyen closed 4 years ago

seanyen commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

seanyen commented 5 years ago

@alexbw this is ready for review and merge. thanks!

seanyen commented 5 years ago

cc @jakirkham @blowekamp

blowekamp commented 5 years ago

It's be great to use this in my SimpleITK package. I have done something very similar here: https://github.com/SimpleITK/SimpleITK/blob/master/SuperBuild/lua.cmake

isuruf commented 5 years ago

Can you also add the license_file entry?

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

seanyen commented 5 years ago

Can you also add the license_file entry?

Sure, btw Lua doesn't place a LICENCE file by convention, but it bakes it in doc/readme.html. That's why I pointed the license_file there.

seanyen commented 5 years ago

@isuruf The test & build is passed, and it is ready to merge. Thanks!