search

conda-forge / lua-feedstock

A conda-smithy repository for lua.
BSD 3-Clause "New" or "Revised" License
3 stars 16 forks source link

try to fix cross compilation #46

Closed wolfv closed 2 years ago

wolfv commented 2 years ago

Let's see if this looks better...

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

izahn commented 2 years ago

I'm not sure understand what we are trying to do here -- basically it just skips make test when cross-compiling?

Pinging @Tobias-Fischer since his PR added the section commented out here.

wolfv commented 2 years ago

yeah when we're cross-compiling we shouldn't run make test (since we can't run foreign binaries without having an emulator).

We have emulators (qemu) on Linux, but there is nothing on osx to emulate osx-arm64. For linux we're compiling ppc64le and aarch64 natively, anyways, so nothing to worry abotu there.

So now we're using the correct CC for the compilation:

arm64-apple-darwin20.0.0-clang -O2 -Wall -Wextra -DLUA_COMPAT_5_3  -fPIC -I$PREFIX/include -L$PREFIX/lib -DLUA_USER_DEFAULT_PATH='"$PREFIX/"' -DLUA_USE_POSIX -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=11.0  -c -o liolib.o liolib.c

which compiles the osx-arm64 binary. the previous build was broken.

I should actually increment the build number, I guess?! And we shoudl move the previous builds to broken.

izahn commented 2 years ago

OK you know this stuff better then I do, let me know when you want me to merge it.

Tobias-Fischer commented 2 years ago

Looks good to me after the last commit (https://github.com/conda-forge/lua-feedstock/pull/46/commits/ac42a386a70ebaabb737cf86aa4e504a69d9d0df) - thanks @wolfv. Indeed we should move the previous build to broken.

Sorry for the initial wrong build!