search

conda-forge / lua-feedstock

A conda-smithy repository for lua.
BSD 3-Clause "New" or "Revised" License
3 stars 16 forks source link

Update windows compilers #50

Closed h-vetinari closed 5 months ago

h-vetinari commented 9 months ago

Hey all

This feedstock is directly specifying vs2017_{{ target_platform }} as a dependency, https://github.com/conda-forge/lua-feedstock/blob/0c68151ab0307a6712ebdcfed84f9569c1076030/recipe/meta.yaml#L25-L29

but should just rely on the {{ compiler('c') }} function to provide the correct compilers on windows. In particular, conda-forge has moved on to vs2019 as the default compiler a while ago already, and doesn't support 32-bit builds anymore.

If you think you need vs2017, please let us know why (generally vs2019 and vs2022 should be fully compatible). If it's really necessary, please use the dedicated mechanism in conda_build_config.yaml for that, i.e.

c_compiler:     # [win]
  - vs2017      # [win]
cxx_compiler:   # [win]
  - vs2017      # [win]

as opposed to specifying it in meta.yaml directly

h-vetinari commented 7 months ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in conda-forge/lua-feedstock#51.