Put `mamba` under `condabin/` too

conda-forge / mamba-feedstock

A conda-smithy repository for mamba.

BSD 3-Clause "New" or "Revised" License

8 stars 36 forks source link

Put `mamba` under `condabin/` too #251

Open jaimergp opened 6 days ago

jaimergp commented 6 days ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Some users have $PREFIX/condabin in PATH, and updating to mamba 2.0 breaks their workflows because it's only putting the executable under bin/, which results in errors like executable not found etc. See https://github.com/conda-incubator/setup-miniconda/actions/runs/11083642307/job/30798086717?pr=367#step:3:906.

github-actions[bot] commented 6 days ago

Hi! This is the friendly automated conda-forge-linting service.

I Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/mamba-feedstock/actions/runs/11103975998.}

github-actions[bot] commented 6 days ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

JohanMabille commented 4 days ago

Back on this, these scripts should actually be generated via mamba shell init -s cmd.exe --root-prefix=$MAMBA_DEFAULT_ENV (or any shell you want to initialise) when running the miniconda installer (same for mamba forge).

jaimergp commented 4 days ago

when running the miniconda installer

I think this should be part of the package itself. Some setups expect mamba.bat under condabin/ because it was there for 1.x, with or without initialization. We can run the initialization routines in the package building itself, like conda does. Would that work?