conda-forge / manif-feedstock

A conda-smithy repository for manif.
BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

Remove overconstraint of numpy dependency #28

Closed traversaro closed 1 year ago

traversaro commented 1 year ago

manifpy interacts with numpy only via pybind11, however as one can read in https://pybind11.readthedocs.io/en/stable/advanced/pycpp/numpy.html :

Note that pybind11/numpy.h does not depend on the NumPy headers, and thus can be used without declaring a build-time dependency on NumPy; NumPy>=1.7.0 is a runtime dependency.

That means that we do not need to declare numpy as an host dependency, and the numpy dependency at runtime is without any particular constraint.

Checklist

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 1 year ago

@conda-forge-admin, please rerender

traversaro commented 1 year ago

This solve the problem that constraining the numpy version results in an old build of manifpy installed, see https://github.com/ami-iit/bipedal-locomotion-framework/pull/578#issuecomment-1354590212 . This is particular problematic as downstream python bindings that use manifpy need to be compiled with the same major version of manifpy, and this constraint is not modeled by conda-forge (see https://github.com/conda-forge/pybind11-feedstock/issues/77 and the issues and PR that link it).

fyi @GiulioRomualdi

traversaro commented 1 year ago

(Unrelated: we need to propagate this also to the blf feedstock @GiulioRomualdi)

traversaro commented 1 year ago

(Unrelated: we need to propagate this also to the blf feedstock @GiulioRomualdi)

Nevermind, numpy is already just a runtime dependency there.

GiulioRomualdi commented 1 year ago

That's wonderful! Thank you @traversaro!

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

traversaro commented 1 year ago

Merging as the ppc64le problem was just a flake, and we can anyhow fix this later.