Closed traversaro closed 2 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
{{ stdlib("c") }}
as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
Hi! This is the friendly conda-forge automerge bot!
Commits were made to this PR after the automerge
label was added. For security reasons, I have disabled automerge by removing the automerge
label. Please add the automerge
label again (or ask a maintainer to do so) if you'd like to enable automerge again!
Something that I overlooked when packaging Python bindings to C++ libraries that wrap eigen vector or matrices via the
pybind/eigen.h
header is that those bindings depends on numpy ABI (via the include sequencepybind/eigen.h
-->pybind/eigen/matrix.h
-->pybind/numpy.h
).We never noticed this as for a long time numpy 1 was just ABI stable, but now that numpy 2 came out, we are seeing problems (see segfaults in https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/pull/69 and https://github.com/conda-forge/bipedal-locomotion-framework-feedstock/pull/72).
For manifpy and
bipedal-locomotion-framework
python users: in a nutshell if we see something strange (i.e. segfaults) in conda environments with old versions of manifpy and bipedal-locomotion-framework, a easy workaround is just to pinnumpy<2
. A cleaner solution would be to prepare a repodata patch (see https://github.com/conda-forge/conda-forge-repodata-patches-feedstock), but as that takes time to do it properly I would prefer to avoid it unless we actually see the need to do it.The pybind11 constrain is instead necessary for https://github.com/conda-forge/pybind11-feedstock/pull/94#issuecomment-2033804227 .
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)