conda-forge / matplotlib-feedstock

A conda-smithy repository for matplotlib.
BSD 3-Clause "New" or "Revised" License
22 stars 58 forks source link

matplotlib v3.6.0 #330

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
matplotlib 3.6.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3065967671, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

tacaswell commented 2 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/matplotlib-feedstock/actions/runs/3069724921.

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/matplotlib-feedstock/actions/runs/3069728260.

ocefpaf commented 2 years ago

@conda-forge-admin please rerender

It is not removing py37 from the CIs :-/

tacaswell commented 2 years ago

@ocefpaf we are conflicting and I think I just made it py3.9+ 🤦🏻

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/matplotlib-feedstock/actions/runs/3069774702.

ocefpaf commented 2 years ago

@ocefpaf we are conflicting and I think I just made it py3.9+ 🤦🏻

Ouch. Sorry! BTW the metadata says py3.8+

tacaswell commented 2 years ago

BTW the metadata says py3.8+

it should be 3.8+ (following NEP29).

ocefpaf commented 2 years ago

it should be 3.8+ (following NEP29).

I'm investigating the re-render issue. The py37 should be gone from the build matrix. There is also some other failures on osx, investigating...

ocefpaf commented 2 years ago

The osx failures above are:

src/_macosx.m:151:55: error: use of undeclared identifier 'NSEventMaskAny'
                  event = [NSApp nextEventMatchingMask: NSEventMaskAny
                                                        ^
  src/_macosx.m:399:47: error: use of undeclared identifier 'NSEventMaskAny'
          event = [NSApp nextEventMatchingMask: NSEventMaskAny
                                                ^
  src/_macosx.m:508:56: error: use of undeclared identifier 'NSEventMaskAny'
      {   NSEvent* event = [NSApp nextEventMatchingMask: NSEventMaskAny
                                                         ^
  src/_macosx.m:512:36: error: use of undeclared identifier 'NSEventTypeApplicationDefined'; did you mean 'NSApplicationDefined'?
         if (!event || [event type]==NSEventTypeApplicationDefined) { break; }
                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                     NSApplicationDefined
  /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:37:5: note: 'NSApplicationDefined' declared here
      NSApplicationDefined        = 15,
      ^
  src/_macosx.m:527:51: error: use of undeclared identifier 'NSEventTypeApplicationDefined'; did you mean 'NSApplicationDefined'?
      NSEvent* event = [NSEvent otherEventWithType: NSEventTypeApplicationDefined
                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                    NSApplicationDefined
  /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:37:5: note: 'NSApplicationDefined' declared here
      NSApplicationDefined        = 15,
      ^
  src/_macosx.m:629:53: error: use of undeclared identifier 'NSWindowStyleMaskTitled'
                                           styleMask: NSWindowStyleMaskTitled
                                                      ^
dopplershift commented 2 years ago

Matplotlib 3.6 now requires macOS 10.12, so I suspect my commit will fix OSX builds.

dopplershift commented 2 years ago

Looks like we might need to set MACOSX_DEPLOYMENT_TARGET as well. While that builds, @ocefpaf to your knowledge is the advice here regarding __osx still relevant? Do we need to worry about conda < 4.8?

ocefpaf commented 2 years ago

Looks like we might need to set MACOSX_DEPLOYMENT_TARGET as well. While that builds, @ocefpaf to your knowledge is the advice here regarding __osx still relevant? Do we need to worry about conda < 4.8?

Good question. I would say no but I'd love to hear from other @conda-forge/core here. 4.8 is quite old and I doubt (hope?) there are many folks using it.

isuruf commented 2 years ago

I think it's fine to add __osx to run. Whatever you prefer. Either run or run_constrained.