conda-forge / matplotlib-feedstock

A conda-smithy repository for matplotlib.
BSD 3-Clause "New" or "Revised" License
22 stars 58 forks source link

matplotlib v3.6.1 #333

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
matplotlib 3.6.1 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3210073218, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 2 years ago

Pypy is failing with:

ERROR: 'HOST_GNU_TYPE'
Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 239, in main
    call_conda_build(action, config)
  File "/opt/conda/lib/python3.10/site-packages/boa/cli/mambabuild.py", line 211, in call_conda_build
    result = api.build(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/api.py", line 186, in build
    return build_tree(
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 3091, in build_tree
    packages_from_this = build(metadata, stats,
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 2374, in build
    newly_built_packages = bundlers[pkg_type](output_d, m, env, stats)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/build.py", line 1616, in bundle_conda
    utils.check_call_env(interpreter_and_args + [dest_file],
  File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 412, in check_call_env
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/conda_build/utils.py", line 392, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/usr/bin/bash', '-e', '/home/conda/feedstock_root/build_artifacts/matplotlib-suite_1665226779967/work/build_base.sh']' returned non-zero exit status 1.
##[error]Bash exited with code '1'.

Not sure what is going on. @mattip is this something simple that we are missing?

tacaswell commented 2 years ago

Matplotlib does look at that in setupext.py, however it is only in the context of trying to build freetype (rather than using the system freetype) which suggests that there is a deeper problem ....

tacaswell commented 2 years ago

Ok, in the builds that work we see:

 src/checkdep_freetype2.c:14:9: note: '#pragma message: Compiling with FreeType version 2.12.1

so that is good.

My guess is now that it is something else in the build chain which is happy.

tacaswell commented 2 years ago

https://github.com/conda-forge/matplotlib-feedstock/pull/329 is related?

tacaswell commented 2 years ago

Also, why did we lose all of the freetype, tk, and zlib pinning?

tacaswell commented 2 years ago

@conda-forge-admin please rerender.

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/matplotlib-feedstock/actions/runs/3221659719.

dopplershift commented 2 years ago

@tacaswell #329 is related, but shouldn't be affecting anything here. That PR fixed cross-builds with the old version of freetype.

It's confusing to me why this works with pypy on ppc64le but not aarch64, when both are being cross-compiled.

dopplershift commented 2 years ago

Adding libtool didn't change the aarch64 failing builds. The osx_arm64 looks spurious, but I'm never completely sure.

mattip commented 2 years ago

ERROR: 'HOST_GNU_TYPE'

That sysconfig value is indeed missing. See conda-forge/gz-math-feedstock/pull/4#issuecomment-1273836303. I don't know how the other cross-compilation targets work without this.

ocefpaf commented 2 years ago

Thanks @mattip! Waiting for a fix in the configs to re-render here.

@tacaswell and @dopplershift do you want to merge to "cash-in" the passing ones and re-run later when the issue is resolved?

dopplershift commented 2 years ago

Thanks @mattip! Sounds good @ocefpaf .

mattip commented 2 years ago

Waiting for a fix in the configs to re-render here.

The fix is in. What would be the easiest way to generate the PyPy aarch64 and ppc64le packages?

dopplershift commented 2 years ago

If we expect everything to "just work" now, we can push an empty commit to main since. Alternatively, we can bump the build in a PR. I think 3.6.2 is imminent, so in that case I'd prefer to wait for the new release (I think it has another PyPy-relevant fix.)

mattip commented 2 years ago

Ok. It makes sense to wait for the next matplotlib release then.