Bump to 3.8.0rc1 - Githubissues

conda-forge / matplotlib-feedstock

A conda-smithy repository for matplotlib.

BSD 3-Clause "New" or "Revised" License

22 stars 57 forks source link

Bump to 3.8.0rc1 #352

Closed dopplershift closed 1 year ago

dopplershift commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dopplershift commented 1 year ago

@ocefpaf I'm not sure why after a re-render this is still trying to build Python 3.8 since I'm explicitly asking to skip <3.9...do you see anything obvious I missed here?

tacaswell commented 1 year ago

It looks like the jobs are running, but do nothing.

ocefpaf commented 1 year ago

I wonder if we need a skip at the top level of the recipe to eliminate that from the CI. Like @tacaswell mentioned, the skip will ensure that nothing is built but that sure waste some CI time.

dopplershift commented 1 year ago

Right, I figured it wasn't doing anything, but would still prefer not to have the jobs at all. Unfortunately, at least running conda smithy rerender locally, even adding a top-level

build:
  skip: true  # [py<39]

isn't triggering any changes.

ocefpaf commented 1 year ago

That most likely a bug in conda-smithy then. @isuruf, any ideas for us here?

dopplershift commented 1 year ago

I'm tempted to go ahead and merge and fix later if someone is motivated.