Fix Windows builds, use call in bld.bat file

mkitti commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mkitti commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/maven-feedstock/actions/runs/5248426834.

mkitti commented 1 year ago

Fix https://github.com/conda-forge/maven-feedstock/issues/23

mkitti commented 1 year ago

There is a minor failure in Windows CI. If it persists, I will see if I can bypass. I'm tempted to merge to resolve #23 .

mkitti commented 1 year ago

@matthiasdiener care to review?

mkitti commented 1 year ago

The failure is

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:3.2.0:clean (clean-target-dir) on project apache-maven: Failed to clean project: Failed to delete %BUILD_PREFIX%\Library\lib\jvm\lib\modules -> [Help 1]

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.maven.settings.GlobalSettingsTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 s - in org.apache.maven.settings.GlobalSettingsTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- clean:3.2.0:clean (clean-target-dir) @ apache-maven ---
[INFO] Deleting %BUILD_PREFIX%\Library (includes = [], excludes = [])
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Maven 3.9.2:
[INFO] 
[INFO] Apache Maven ....................................... SUCCESS [ 19.749 s]
[INFO] Maven Model ........................................ SUCCESS [ 11.724 s]
[INFO] Maven Artifact ..................................... SUCCESS [  3.837 s]
[INFO] Maven Plugin API ................................... SUCCESS [  2.080 s]
[INFO] Maven Builder Support .............................. SUCCESS [  1.461 s]
[INFO] Maven Model Builder ................................ SUCCESS [ 10.650 s]
[INFO] Maven Settings ..................................... SUCCESS [  1.095 s]
[INFO] Maven Settings Builder ............................. SUCCESS [  1.616 s]
[INFO] Maven Repository Metadata Model .................... SUCCESS [  1.874 s]
[INFO] Maven Artifact Resolver Provider ................... SUCCESS [  8.252 s]
[INFO] Maven Core ......................................... SUCCESS [ 46.414 s]
[INFO] Maven SLF4J Simple Provider ........................ SUCCESS [  7.200 s]
[INFO] Maven Embedder ..................................... SUCCESS [  8.701 s]
[INFO] Maven Compat ....................................... SUCCESS [ 25.766 s]
[INFO] Apache Maven Distribution .......................... FAILURE [  9.186 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:40 min
[INFO] Finished at: 2023-06-13T00:06:00Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:3.2.0:clean (clean-target-dir) on project apache-maven: Failed to clean project: Failed to delete %BUILD_PREFIX%\Library\lib\jvm\lib\modules -> [Help 1]

mkitti commented 1 year ago

The restriction on OpenJDK 17 or earlier is due to the following error.

[ERROR] Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.676 s <<< FAILURE! - in org.apache.maven.project.ProjectBuilderTest
[ERROR] org.apache.maven.project.ProjectBuilderTest.testLocationTrackingResolution  Time elapsed: 0.06 s  <<< ERROR!
java.lang.IllegalStateException: java.net.MalformedURLException: Illegal character found in host: '{'
    at org.apache.maven.repository.TestRepositoryConnector.<init>(TestRepositoryConnector.java:55)
    at org.apache.maven.repository.TestRepositoryConnectorFactory.newInstance(TestRepositoryConnectorFactory.java:36)
    at org.eclipse.aether.internal.impl.DefaultRepositoryConnectorProvider.newRepositoryConnector(DefaultRepositoryConnectorProvider.java:121)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:535)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:260)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:242)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact(DefaultRepositorySystem.java:277)
    at org.apache.maven.project.ProjectModelResolver.resolveModel(ProjectModelResolver.java:172)
    at org.apache.maven.project.ProjectModelResolver.resolveModel(ProjectModelResolver.java:218)
    at org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:1009)
    at org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:801)
    at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:327)
    at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:243)
    at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:176)
    at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:123)
    at org.apache.maven.AbstractCoreMavenComponentTestCase.createMavenSession(AbstractCoreMavenComponentTestCase.java:137)
    at org.apache.maven.AbstractCoreMavenComponentTestCase.createMavenSession(AbstractCoreMavenComponentTestCase.java:118)
    at org.apache.maven.AbstractCoreMavenComponentTestCase.createMavenSession(AbstractCoreMavenComponentTestCase.java:114)
    at org.apache.maven.project.ProjectBuilderTest.testLocationTrackingResolution(ProjectBuilderTest.java:318)
    at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
    at java.base/java.lang.reflect.Method.invoke(Method.java:578)
    at junit.framework.TestCase.runTest(TestCase.java:177)
    at junit.framework.TestCase.runBare(TestCase.java:142)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:130)
    at junit.framework.TestSuite.runTest(TestSuite.java:241)
    at junit.framework.TestSuite.run(TestSuite.java:236)
    at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
    at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:377)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:284)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:248)
    at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
    at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
    at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
Caused by: java.net.MalformedURLException: Illegal character found in host: '{'
    at java.base/java.net.URL.<init>(URL.java:798)
    at java.base/java.net.URL.<init>(URL.java:646)
    at java.base/java.net.URL.<init>(URL.java:582)
    at org.apache.maven.repository.TestRepositoryConnector.<init>(TestRepositoryConnector.java:53)
    ... 38 more
Caused by: java.lang.IllegalArgumentException: Illegal character found in host: '{'
    at java.base/java.net.URLStreamHandler.setURL(URLStreamHandler.java:522)
    at java.base/java.net.URLStreamHandler.parseURL(URLStreamHandler.java:325)
    at java.base/sun.net.www.protocol.file.Handler.parseURL(Handler.java:56)
    at java.base/java.net.URL.<init>(URL.java:793)
    ... 41 more

mkitti commented 1 year ago

I will merge tomorrow if there are no objections.

mkitti commented 1 year ago

@hinerm this should resolve the maven issue on Windows.

conda-forge / maven-feedstock

Fix Windows builds, use call in bld.bat file #24