remove openjdk upper bound limit

conda-forge / maven-feedstock

A conda-smithy repository for maven.

BSD 3-Clause "New" or "Revised" License

2 stars 12 forks source link

remove openjdk upper bound limit #37

Closed jdmarques closed 4 months ago

jdmarques commented 4 months ago

Hello, I think you should remove this upper limit on the OpenJDK. From the Maven documentation, the limit is only on JDK 8, " Maven 3.9+ requires JDK 8 or above to execute" source: https://maven.apache.org/download.cgi

why set this upper bound limit?

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mkitti commented 4 months ago

There have been some conda-forge specific issues here in the past. What we really need here are better tests.

My bandwidth as a maintainer is limited until mid-July. I would be willing to do a trial in late July.

If you would like to see proceed before then, please add additional tests across multiple platforms, including Windows.

mkitti commented 4 months ago

There have been some conda-forge specific issues here in the past. What we really need here are better tests.

My bandwidth as a maintainer is limited until mid-July. I would be willing to do a trial then

If you would like to see proceed before then, please add additional tests across multiple platforms.

See https://github.com/conda-forge/maven-feedstock/pull/24#issuecomment-1588465291

jdmarques commented 4 months ago

hello @mkitti, from what I see in https://github.com/conda-forge/maven-feedstock/pull/24#issuecomment-1588465291 what fixed the issue was the flag to ignore the cleanup errors "-Dmaven.clean.failOnError=false" and not the version limit. Am I missing something?

From the CI logs the build from this PR run with "openjdk: 22.0.1-h57928b3_0 conda-forge" just fine. I can try to add a test but I need more information about the actual issue.

mkitti commented 4 months ago

I have some bandwidth to try this now, and plan to merge in a few hours.

Pinging @ctrueden and @hinerm

mkitti commented 4 months ago

@conda-forge-admin, please rerender

jdmarques commented 4 months ago

thanks @mkitti