search

conda-forge / maven-feedstock

A conda-smithy repository for maven.
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Remove ext folder #7

Closed hadim closed 5 years ago

hadim commented 5 years ago

ext folder still persist in recent maven version and openjdk >=9 can't run if that folder exists (I know it's weird...).

The folder is empty anyway in the maven repo so I think it's ok to delete it.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hadim commented 5 years ago

@conda-forge-admin, please update circle

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I updated the circle-ci deploy key and followed the project.

hadim commented 5 years ago

conda-build >=3.17 looks broken for OSX and Linux:

 File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 1628, in build
    newly_built_packages = bundlers[pkg_type](output_d, m, env, stats)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 954, in bundle_conda
    files = post_process_files(metadata, initial_files)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/build.py", line 818, in post_process_files
    post_build(m, new_files, build_python=python)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 1010, in post_build
    check_overlinking(m, files)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 947, in check_overlinking
    m.config.channel_urls)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 875, in check_overlinking_impl
    build_prefix, build_prefix_substitution)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/post.py", line 597, in _collect_needed_dsos
    envroot=run_prefix)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/os_utils/liefldd.py", line 603, in __call__
    value = self.func(*args, **kw)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/os_utils/liefldd.py", line 632, in get_linkages_memoized
    recurse=recurse, sysroot=sysroot, envroot=envroot, arch=arch)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/os_utils/liefldd.py", line 414, in get_linkages
    sysroot=sysroot, envroot=envroot, arch=arch)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/os_utils/liefldd.py", line 373, in inspect_linkages_lief
    sysroot)
  File "/Users/travis/miniconda3/lib/python3.6/site-packages/conda_build/os_utils/liefldd.py", line 127, in get_rpaths
    rpaths.append(exe_dirname.replace('\\', '/'))
AttributeError: 'NoneType' object has no attribute 'replace'

I can reproduce this locally and make it work by downgrading to 3.16.

hadim commented 5 years ago

In the meantime, anyone knows how to fix conda-build to 3.16?

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.