conda-forge / mesalib-feedstock

A conda-smithy repository for mesalib.
BSD 3-Clause "New" or "Revised" License
2 stars 16 forks source link

Use gcc from the container #10

Closed isuruf closed 6 years ago

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

doutriaux1 commented 6 years ago

@isuruf why do you prefer to use the container's gcc rather than the conda one? Does that introduces risks of incompatibility on some newer systems?

isuruf commented 6 years ago

I was trying to use mesalib at https://github.com/conda-forge/paraview-feedstock/pull/2 and it failed because the paraview recipe was using the container's gcc which is older than what this package was compiled with.

doutriaux1 commented 6 years ago

@isuruf I'm ok to merge this in , you should probably update the build number on it though. Also it if turns out it breaks our software I would have to revert this pronto. Maybe we could trigger a rebuild on paraview? So they use the same newer gcc?

isuruf commented 6 years ago

Yeah, I have a PR in paraview that uses the newer conda package that works fine.