Update to version 21.2.5 - Githubissues

conda-forge / mesalib-feedstock

A conda-smithy repository for mesalib.

BSD 3-Clause "New" or "Revised" License

2 stars 16 forks source link

Update to version 21.2.5 #34

Closed matthiasdiener closed 2 years ago

matthiasdiener commented 2 years ago

Supersedes #27 #30 #33

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthiasdiener commented 2 years ago

This is ready for review @conda-forge/mesalib

hmaarrfk commented 2 years ago

This looks good. A small nit on the recipe. But otherwise great! Did you want to use run-exports for the X11 stuff? It seems that at least libxcb has them, not sure about the others.

matthiasdiener commented 2 years ago

Did you want to use run-exports for the X11 stuff? It seems that at least libxcb has them, not sure about the others.

Do you mean for pin_subpackage ? Based on https://abi-laboratory.pro/index.php?view=timeline&l=mesa , what would the right value be?

Edit: Or do you mean adding pin_compatible for e.g. libxcb? @hmaarrfk

hmaarrfk commented 2 years ago

More that you could remove the line libxcb from the run section since recent builds of libxcb have: https://github.com/conda-forge/libxcb-feedstock/blob/master/recipe/meta.yaml#L23

However, that is a real nit I don't care much about. I just had one question about a comment you left.

hmaarrfk commented 2 years ago

Mostly inspired by https://github.com/kovidgoyal/kitty/issues/355

hmaarrfk commented 2 years ago

Maybe we should just punt. This seems to be an issue for a while https://github.com/conda-forge/mesalib-feedstock/issues/16

hmaarrfk commented 2 years ago

Lets revert the tests for gl and refer to the issue above: https://github.com/conda-forge/mesalib-feedstock/issues/16

hmaarrfk commented 2 years ago

Sorry i repeated myself to avoid the use of jargon in my comment. This is a go!

hmaarrfk commented 2 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

matthiasdiener commented 2 years ago

Sorry i repeated myself to avoid the use of jargon in my comment. This is a go!

Great, thank you!