conda-forge / meshcat-python-feedstock

A conda-smithy repository for meshcat-python.
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

De-vendor meshcat dependency #1

Open traversaro opened 3 years ago

traversaro commented 3 years ago

Not sure if possible or desirable, but let's keep track of it. See https://github.com/conda-forge/staged-recipes/pull/14312#issuecomment-803295967 .

danzimmerman commented 2 years ago

@traversaro Maybe relevant to whether it's desirable, I needed to modify index.js with changes from meshcat/pulls/99 and rebuild main.min.js to get Conda-installed meshcat-python 0.3.1 to work properly for me:

https://github.com/rdeits/meshcat-python/issues/84#issuecomment-953947232

traversaro commented 2 years ago

Yes, this is definitely a good example in which if we packaged meshcat separately we would just need to update meshcat, instead of waiting for meshcat-python to update its own vendored meshcat.

In the meanwhile, if you can think of any way of patching the existing meshcat-python to use the new meshcat, feel free to open a PR.