Closed jankatins closed 8 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
This is tested locally with a new install (removed all miktex packages, cleaned out my miktex paths in %USERPROFILE%, build and installed this one). And it worked with a nbconvert: took a bit longer the first time, but no package install questions were asked and I got a PDF on all attempts.
So, I would really like to have this included ASAP, so that the problem fixed here isn't affecting any users...
Any reviewers? @ocefpaf @ivoflipse @Korijn ?
-> IMO merge if any of you are satisfied...
LGTM!
Merged, thanks for the review!
The portable install has the problem that additional packages and things like caches are placed in the install location. Condas way of linking files into the environments (even the root env) means that information is shared between envs and installs (e.g. the latex package DB is shared, but not the packages itself; also the package DB is reset on update but the package files itself are kept).
To avoid this, the miktex install is changed from "Portable" to "Regular" and the paths are manually set so that the "common" data/config paths still point to the miktex install in the conda env, but user installed/changed data now ends up in the user profile path:
No packages are added to the default install as that would also add cache files and so on which include hardcoded paths. Until that is understood, lets just let the user download all the packages in the post-link.bat...
Closes: https://github.com/conda-forge/miktex-feedstock/issues/1