conda-forge / miktex-feedstock

A conda-smithy repository for miktex.
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Update to 23.5, turn into proper portable installation #24

Closed mbargull closed 1 year ago

mbargull commented 1 year ago

Checklist

fixes gh-19 fixes gh-22 fixes gh-25

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

xhochy commented 1 year ago

@conda-forge-admin please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the 22.8.28 branch of mbargull-feedstocks/miktex-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts or PRs from forks made from organization forks cannot be rerendered because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/miktex-feedstock/actions/runs/4434411718.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

h-vetinari commented 1 year ago

Thanks for tackling this! ❤️

mbargull commented 1 year ago

Thanks for tackling this! heart

Now let's also hope that the research at Anaconda for getting an updated MinGW-w64 + UCRT toolchain bears fruit ;).