conda-forge / miniforge

A conda-forge distribution.
https://conda-forge.org/miniforge
Other
6.14k stars 318 forks source link

Resolve action deprecation warnings #381

Closed dbast closed 1 year ago

dbast commented 1 year ago

Current warnings are:

The warnings are caused by conda-incubator/setup-miniconda/svenstaro/upload-release-action and have proposed fixes:

While the proposed fixes are fine, the warnings caused by conda-incubator/setup-miniconda can be avoided by using the Github runner pre-installed miniconda, which also saves some seconds for each action run (see also https://github.com/actions/runner-images/search?q=miniconda where the runners are defined)

xhochy commented 1 year ago

I would also prefer to keep setup-miniconda here as we are actually in a miniconda repo. If performance is an issue, we should be using mamba in the action or switch to provision-with-micromamba.

dbast commented 1 year ago

Well, personal preferences... the action anyways installs nothing in the bundled situation https://github.com/conda-incubator/setup-miniconda/blob/main/src/installer/bundled-miniconda.ts so wouldn't be required at all if the bundled installation is activated directly as done here.

Closing as fixing the setup-miniconda action will resolve it.

jakirkham commented 1 year ago

Updating the setup-miniconda in PR ( https://github.com/conda-forge/miniforge/pull/383 )