Switch to constructor >=3.4.2

conda-forge / miniforge

A conda-forge distribution.

https://conda-forge.org/miniforge

Other

5.99k stars 317 forks source link

Switch to constructor >=3.4.2 #405

Closed dbast closed 1 year ago

dbast commented 1 year ago

~~The next soon to be happening constructor release contains lots of changes.~~ Released

Pinning the current stable version allows to later consciously unpin it again, while the unpin PR artefacts can serve as test point to check that all the installers continue to work fine, before tagging a new release.

Requiring constructor ~~>=3.4.1~~ >=3.4.2 to see how it builds.

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

hmaarrfk commented 1 year ago

Lets leave this out here for abit. I'm somewhat interested in trying the new release. We've use development releases before with success.

hmaarrfk commented 1 year ago

But it might be good to "merge" this quickly when problems do arise.

dbast commented 1 year ago

new version will be available soon https://github.com/conda-forge/constructor-feedstock/pull/66

jaimergp commented 1 year ago

3.4.1 is out now!

hmaarrfk commented 1 year ago

It might be worth a new release. we would have to pin setuptools to 65.

jaimergp commented 1 year ago

Windows not happy :(

dbast commented 1 year ago

looks like constructor 3.4.1 was not available for windows yet, due to channel mirroring not finished.

hmaarrfk commented 1 year ago

Well maybe this is going better than expected. I do want to go through the logs and ensure that setup tools 65 is installed.

Downgrades are painful.

hmaarrfk commented 1 year ago

I've pinned setuptools and trying to update conda. We could also try to update mamba https://github.com/conda-forge/miniforge/pull/406

hmaarrfk commented 1 year ago

Shall we try to update mamba as well? I guess my point is that i'll try to create a release as soon as we merge this, so it would be good to get a few of these "updates" done at once. With the conda version change, we at least get a "visible" change in the version number for Miniforge3 and Mambaforge!

jaimergp commented 1 year ago

I say let's try! If it solves, it should work :D

jaimergp commented 1 year ago

Some users are experiencing an issue with pre-install logic (see https://github.com/conda/constructor/issues/621), so there's a chance we publish 3.4.2 soon. If we are not in a rush, can we wait for that release?

hmaarrfk commented 1 year ago

ok, lets wait, but our CIs test the install process (in batch mode) so presumably we were OK.

boa needs a new release, otherwise we can't install mamba 1.2.0 https://github.com/conda-forge/boa-feedstock/blob/main/recipe/meta.yaml#L27

jaimergp commented 1 year ago

ok, lets wait, but our CIs test the install process (in batch mode) so presumably we were OK.

Our CIs didn't catch this either. Seems to be a misconfiguration in some systems, but we have added some workarounds, so hopefully it's ok now?

hmaarrfk commented 1 year ago

Did you want to downgrade the conda version to something particular?

dbast commented 1 year ago

Here we go constructor 3.4.2 https://github.com/conda-forge/constructor-feedstock/pull/67

jaimergp commented 1 year ago

Did you want to downgrade the conda version to something particular?

I am fine with 22.11 for now!

hmaarrfk commented 1 year ago

@dbast i'm taking your rocket as approval. Lets try to start the builds.