search

conda-forge / miniforge

A conda-forge distribution.
https://conda-forge.org/miniforge
Other
6k stars 317 forks source link

Rebuild `setuptools` 65 #409

Open jakirkham opened 1 year ago

jakirkham commented 1 year ago

As discussed in issue ( https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/3973 ), conda-build fails with setuptools 66. A hot-fix for conda-build was added in PR ( https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/387 ). Though it looks like the installer may already ship with setuptools 66. Think we may need to rebuild it with setuptools pinned to 65 to avoid issues with conda-build. Though users could always update to a newer setuptools if they prefer

hmaarrfk commented 1 year ago

The last build log on main shows version 65

https://github.com/conda-forge/miniforge/actions/runs/3766197110/jobs/6402449244#step:4:322

jakirkham commented 1 year ago

Yeah think you are right. Yesterday we had seen 66 show up somewhere and then get downgraded. So thought maybe it was included in the installer, but in the end think something else was going on

Maybe we can leave this open as a reminder? At least until we've figured out a better solution

hmaarrfk commented 1 year ago

yes agreed.

jakirkham commented 1 year ago

How do you think we should handle this at this point?

hmaarrfk commented 1 year ago

i'm not sure what the status is on compatibility. I've been pinning it in the installer.

hmaarrfk commented 1 year ago

users are free to update it. the installer just needs to be "stable"

jakirkham commented 1 year ago

No worries. Pinning in the installer makes sense. Agree users can update.

In terms of fixing the issue in conda-build, PR ( https://github.com/conda/conda-build/pull/4443 ) should do that. Waiting for feedback atm.