Build with constructor 3.4.4

conda-forge / miniforge

A conda-forge distribution.

https://conda-forge.org/miniforge

Other

5.79k stars 309 forks source link

Build with constructor 3.4.4 #472

Closed jaimergp closed 1 year ago

jaimergp commented 1 year ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

jaimergp commented 1 year ago

Ok @conda-forge/miniforge, this is ready for review. I've tested the GHA artifacts locally and the Windows uninstallers are patched properly, preventing the problems described in https://www.anaconda.com/blog/windows-installer-security-fix.

isuruf commented 1 year ago

Thanks

jaimergp commented 1 year ago

Thank you @isuruf, and also for the new tag! I see it's been marked as a pre-release; is that a temporary decision while we wait for something else or are we ok turning it into a proper release at some point? Right now it does the job as a repository for fixed installers than can be accessed from the (upcoming) blog post, so no rush in making a decision here, but it would be nice if new installs would start using the fixed installers more or less soonish.

isuruf commented 1 year ago

See the release process at https://github.com/conda-forge/miniforge#release