search

conda-forge / miniforge

A conda-forge distribution.
https://conda-forge.org/miniforge
Other
6.24k stars 323 forks source link

Update to conda 23.11, mamba 1.5.5, libmamba_solver 23.12 #523

Closed hmaarrfk closed 9 months ago

hmaarrfk commented 10 months ago

This reverts https://github.com/conda-forge/miniforge/pull/522 and in effect updates to 23.10 (or soon 23.11)

Closes https://github.com/conda-forge/miniforge/issues/511

Checklist

mbargull commented 10 months ago

Thanks @hmaarrfk. I'll get back to you once we know more on when/how/if we get a new conda release with the mentioned issue resolved.

mbargull commented 9 months ago

We have an build for mamba=1.5.5 pending at https://github.com/conda-forge/mamba-feedstock/pull/206 . Once that one is up, we can include that update here.

With conda=23.11.0 and mamba=1.5.5 we should have all major issues I know of covered and I'd say we could then finally proceed with a new Miniforge release :).

jaimergp commented 9 months ago

conda-libmamba-solver 23.12.0 is out now, solving the "KeyError" issues too.

jaimergp commented 9 months ago

I think we should specify this key too: https://conda.github.io/constructor/construct-yaml/#user-requested-specs

This would allow us to have a cleaner history, without pinning key specs to certain versions. For example:

user_requested_specs:
{% if name.endswith("pypy3") %}
  - python 3.9.* *_pypy
{% else %}
  - python 3.10.*
{% endif %}
  - pip
  - conda >={{ version.split("-")[0] }}
  - mamba >={{ mamba_version }}
  - miniforge_console_shortcut 1.*  # [win]

Note we have left conda-libmamba-solver out so it's not in history and can freely move (conda requires it now). We only specify the "leave" nodes, and with >= constraints so they can be easily upgraded. This should alleviate issues like https://github.com/mamba-org/mamba/issues/3033#issuecomment-1841583634.

mbargull commented 9 months ago

@hmaarrfk, @jaimergp, good to go?

jakirkham commented 9 months ago

This would be a prerelease initially right?

Think ideally we would make the release official Monday or Tuesday in case we need hands available to resolve issues (should any arise)

hmaarrfk commented 9 months ago

I think it makes sense to make the pre-release this weekend, then to make a release on monday

jaimergp commented 9 months ago

Yep, I have some time to babysit the release this week.

hmaarrfk commented 9 months ago

if somebody else presses merge, i can start the pre-release.

beckermr commented 9 months ago

@mbargull @jaimergp @hmaarrfk can we get push this ahead? Shall I merge?

mbargull commented 9 months ago

@mbargull @jaimergp @hmaarrfk can we get push this ahead? Shall I merge?

Ah, didn't notice @hmaarrfk's last comment. Thanks for the ping. Merge, merge

hmaarrfk commented 9 months ago

how are we feeling about the latest conda-smithy woes. I haven't been keeping up with the details so I was hesitant to merge myself.

hmaarrfk commented 9 months ago

Just FYI, prerelease started. we can mark it as release when we want to in an hour or so https://github.com/conda-forge/miniforge/releases/tag/23.11.0-0

mbargull commented 9 months ago

how are we feeling about the latest conda-smithy woes. I haven't been keeping up with the details so I was hesitant to merge myself.

That was just due to a minor change in conda-build=3.28.2 that broke an assumption in downstream smithy code. ref: https://github.com/conda/conda-build/issues/5125 It should be taken care of with the new smithy release and adjusted dependencies for older builds. Shouldn't affect Miniforge.

Just FYI, prerelease started. we can mark it as release when we want to in an hour or so https://github.com/conda-forge/miniforge/releases/tag/23.11.0-0

Thanks! (We had one build stalled; I restarted it and it just finished so that all release artifacts should be available now.)

hmaarrfk commented 9 months ago

Ok. Seems like we are set. I won't have time to pull a release today in case of errors but I can help tomorrow.

If somebody else wants to take responsibility today then the tag seems ready to be marked as latest