conda-forge / mlflow-feedstock

A conda-smithy repository for mlflow.
BSD 3-Clause "New" or "Revised" License
1 stars 26 forks source link

Include JS artifacts in `mlflow-ui` #176

Closed borchero closed 5 months ago

borchero commented 5 months ago

Fixes #175

Checklist

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 5 months ago

$SP_DIR/mlflow/server/js/node_modules should probably be deleted again from the installed files.

borchero commented 5 months ago

Windows build fails with this issue

The lockfile would have been modified by this install, which is explicitly forbidden.

Any idea how to fix this, does this require a patch?

jrbourbeau commented 5 months ago

Thanks @borchero @xhochy!