Fix rerendering bug - Githubissues

conda-forge / mpi4py-feedstock

A conda-smithy repository for mpi4py.

BSD 3-Clause "New" or "Revised" License

4 stars 20 forks source link

Fix rerendering bug #40

Closed leofang closed 3 years ago

leofang commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 3 years ago

@conda-forge-admin, please rerender

leofang commented 3 years ago

@conda-forge/core As discussed on Gitter (https://gitter.im/conda-forge/conda-forge.github.io?at=6004fff8252c0a6ded18cdd4), the first commit e1a77b0 doesn't seem to be the right solution, but it's the only one I found to unblock rerendering. Thoughts?

beckermr commented 3 years ago

@conda-forge-admin rerender

beckermr commented 3 years ago

Well that worked! IDK why @leofang but my guess is that this is a safe fix.

beckermr commented 3 years ago

I'd hold off on merging though. The ci support files look odd, with openmpi info in the mpich ones. :/

leofang commented 3 years ago

I'd hold off on merging though. The ci support files look odd, with openmpi info in the mpich ones. :/

Agreed. I am also looking into it locally, but I am not sure if I wanna dive deep into conda-build/conda-smithy internals again for this...😂

leofang commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

leofang commented 3 years ago

@beckermr Thanks for working on this with me! I think your idea was right that the appearance of openmpi in Jinja somehow caused strange behavior. By switching to selectors the ci support files look normal now. PTAL.

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
drone: passed
travis: passed
azure: passed

Thus the PR was passing and merged! Have a great day!