conda-forge / mpi4py-feedstock

A conda-smithy repository for mpi4py.
BSD 3-Clause "New" or "Revised" License
4 stars 20 forks source link

add major version pin to run_exports #78

Closed minrk closed 3 months ago

minrk commented 3 months ago

when mpi4py is a build dependency, don't assume next major version will be ABI compatible

this will result in e.g. mpi4py >=4.0.2,<5.0a0 when building with mpi4py 4.0.2. Only affects packages with mpi4py in host dependencies.

ref: https://github.com/conda-forge/fenics-feedstock/issues/212

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

leofang commented 3 months ago

We might have to mark the previous builds as broken since we can't patch repodata to fix run exports.

minrk commented 3 months ago

I don't think we need to patch past builds of mpi4py since there shouldn't be future builds using them, but some downstream packages may need patches if they have been built against mpi4py. I'm not sure if fenics is the only one or if there are more: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/808