search

conda-forge / mpi4py-feedstock

A conda-smithy repository for mpi4py.
BSD 3-Clause "New" or "Revised" License
4 stars 20 forks source link

Rebuild for python 3.13 #79

Closed regro-cf-autotick-bot closed 2 weeks ago

regro-cf-autotick-bot commented 2 weeks ago

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

dalcinl commented 2 weeks ago

Too quick to merge. There is a small issue related to changes in Python 3.13, we need a patch. https://github.com/mpi4py/mpi4py/commit/2dc9dd2f35f0aff45c288274a7010bf737722901

minrk commented 2 weeks ago

Sorry about that. What test is missing that would have failed without the patch?

Looking at https://github.com/mpi4py/mpi4py/pull/527/files, that doesn't look relevant to conda builds, but I'm not sure. Neither I_MPI_ROOT nor MSMPI_BIN env will be defined, so the changed code looks to be a no-op in our context, to me. I would expect setting them more likely to break conda mpi4py.

dalcinl commented 2 weeks ago

What test is missing that would have failed without the patch?

The *.pth files are processed at Python initialization, and if any failure occurs, then you just get a warning printed, it is not an error.

Let's continue in #80