search

conda-forge / mpich-feedstock

A conda-smithy repository for mpich.
BSD 3-Clause "New" or "Revised" License
2 stars 26 forks source link

run_exports #20

Closed minrk closed 6 years ago

minrk commented 6 years ago

Building against mpich 3.2.1 will have an automatic runtime dependency on mpich>=3.2.1,<3.3.0

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dalcinl commented 6 years ago

Are you sure about this? MPICH's ABI is quite stable. On the other side, MPICH do not make new releases so often, so I guess this OK.

minrk commented 6 years ago

This is duplicating the same pinning most downstream packages are doing (3.2.* is equivalent to >=3.2.0,<3.3.0), so I think it should be fine.

The two ways we could relax this:

  1. min_pin='x.x' would allow packages built against 3.2.1 to install with 3.2.0 (probably fine, and exactly the pinning we are using now with 3.2.*) (I updated the PR to reflect this)
  2. max_pin='x' would allow packages built against 3.2.x to run with 3.3.x (and 3.4.x, etc.). Does mpich guarantee ABI compatibility across minor versions?
dalcinl commented 6 years ago

I think ABI compatibility should be guaranteed on minor versions, however I'm fine with 3.2.*.

minrk commented 6 years ago

Sounds good. We can try an experiment relaxing this later when there's another version.