Update to mpich 3.4, using CH3 as default configuration

conda-forge / mpich-feedstock

A conda-smithy repository for mpich.

BSD 3-Clause "New" or "Revised" License

2 stars 26 forks source link

Update to mpich 3.4, using CH3 as default configuration #53

Closed brianv0 closed 3 years ago

brianv0 commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

z mpich 3.4 uses CH4 device configuration by default, but we now need an OFI (http://libfabric.org) or UCX (http://openucx.org) library to build CH4. Rather than making a decision on that, I set the default back to CH3 for now.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

brianv0 commented 3 years ago

@conda-forge-admin, please rerender

brianv0 commented 3 years ago

It seems config.sub/config.guess for (unfortunately vendored and adjustable by configure, json-c) needs to be patched for osx arm64.

dalcinl commented 3 years ago

@brianv0 Could you confirm whether this ready for merge?

brianv0 commented 3 years ago

Yes it’s ready. The large number of lines changes is from patching all config.sub and config.guess files (I opened an issue upstream about this)

leofang commented 3 years ago

Just curious, wouldn't it be safer if the patch were only applied to osx arm64?

dalcinl commented 3 years ago

Just curious, wouldn't it be safer if the patch were only applied to osx arm64?

Perhaps. Are you thinking about adding the # [osx and arm64] selector to the patch?

dalcinl commented 3 years ago

@brianv0 How did you generate the patch? Did you run ./autogen.sh on MPICH's git repo with updated autotools supporting macOS ARM64?

leofang commented 3 years ago

Just curious, wouldn't it be safer if the patch were only applied to osx arm64?

Perhaps. Are you thinking about adding the # [osx and arm64] selector to the patch?

Yap. Of course it is ok to leave as is if no one complains. Just wondering when reading the recipe here. The patch is a bit nerve wrecking...

leofang commented 3 years ago

Friendly ping @brianv0, as we'll need a more robust way to generate the patch for arm64.