Missing CROSS_F77_SIZEOF_LOGICAL

conda-forge / mpich-feedstock

A conda-smithy repository for mpich.

BSD 3-Clause "New" or "Revised" License

2 stars 26 forks source link

Missing CROSS_F77_SIZEOF_LOGICAL #86

Closed minrk closed 9 months ago

minrk commented 9 months ago

missing env generated with perl maint/gen_cross.pl, as suggested in https://github.com/pmodels/mpich/issues/5380#issuecomment-865968705

I believe this closes #85, but I don't know how to add a test

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dalcinl commented 9 months ago

The issue is related to cross-compiling, and in that case we cannot compile code and run a test to check that MPI_LOGICAL is not MPI_DATATYPE_NULL.

The only check I can imagine is to use grep and fail if the MPI_LOGICAL=MPI_DATATYPE_NULL string is in mpif.h, but I'm not really sure the extra work is worth it.

minrk commented 9 months ago

@dalcinl yeah, that's kind of what I was thinking.

https://github.com/conda-forge/mumps-feedstock/pull/102 should show whether it worked, though not before merging.