conda-forge / msmpi-feedstock

A conda-smithy repository for msmpi.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

Use installer outputs & Fix (de)activate scripts #11

Closed leofang closed 3 years ago

leofang commented 3 years ago

Close #2.

This PR does 3 things:

  1. Use Windows installer and install (not extract!) to $PREFIX\Library
  2. Fix (de)activate scripts to not print debug messages in user environments
  3. Erase the pre-installed MPI from Conda-Forge's VM image so that downstream packages can test MPI against msmpi

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

leofang commented 3 years ago

Hmmm, ok, so if we remove the old MPI runtime and then install, -installroot will work...Interesting.

leofang commented 3 years ago

Hmmm, ok, so if we remove the old MPI runtime and then install, -installroot will work...Interesting.

I should have noticed this in https://github.com/conda-forge/msmpi-feedstock/pull/7/commits/ddccb520f0683468179129660a51ea8f3b091d55 from #7!!!

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=308809&view=results

leofang commented 3 years ago

PR description updated. Note that using the installer properly should fix the 32 vs 64 bit issue (default is 32 bit if extracting from the exe directly)...

leofang commented 3 years ago

Verified working in downstream packages: