Switch to official installer

conda-forge / msmpi-feedstock

A conda-smithy repository for msmpi.

BSD 3-Clause "New" or "Revised" License

1 stars 7 forks source link

Switch to official installer #6

Closed leofang closed 3 years ago

leofang commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 3 years ago

@conda-forge-admin, please rerender

leofang commented 3 years ago

OK. Switching to the official installer works. Let me try adding a few simple tests.

leofang commented 3 years ago

@mccarthyryanc @RyanMcCarthy-NOAA @dalcinl This is ready. Once this 10.1.1 fix is in, I will proceed to package 10.1.2. Then, we can rebuild mpi4py.

dalcinl commented 3 years ago

Then, we can rebuild mpi4py.

You should add the following trivial line to the test section of mpi4py's recipe:

python -c 'from mpi4py import MPI; print(MPI.get_vendor())'

dalcinl commented 3 years ago

I suggest to merge this MR with a squash. There is no point on keeping this messy history.

leofang commented 3 years ago

Note: Another reason to not test mpi4py in this repo is that it leaks the Python dependency, causing Python to become a run dependency. I think this is a bug in either conda-build or conda-smithy.

leofang commented 3 years ago

Thanks guys!