search

conda-forge / msprime-feedstock

A conda-smithy repository for msprime.
BSD 3-Clause "New" or "Revised" License
1 stars 4 forks source link

missing dependency on newick? #64

Open grahamgower opened 2 years ago

grahamgower commented 2 years ago

setup.cfg has newick as a listed dependency. I see this is a "soft" dependency, in the sense that failure to import just limits feature availablility (in msprime/species_trees.py). But it means that pip check fails after installing the msprime conda package. Probably its fine to just add it to the conda recipe run: dependencies?

grahamgower commented 2 years ago

Oh, and maybe add a pip check to the test: section of the recipe. FYI, grayskull adds a pip check test by default, which is how I found this issue.

jeromekelleher commented 2 years ago

Hmm, not sure how this one crept past. Unfortunately there's no conda-forge package for newick, so it's not straightforward to put in a dependency.

I guess we could add it as an optional dependency in the setup.cfg? I doubt it's used much.