MNT: rerender - Githubissues

conda-forge / mss-feedstock

A conda-smithy repository for mss.

BSD 3-Clause "New" or "Revised" License

1 stars 8 forks source link

MNT: rerender #179

Open conda-forge-admin opened 2 months ago

conda-forge-admin commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #178.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

[ ] Bump the build number if needed

Fixes #178

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

h-vetinari commented 2 months ago

@conda-forge-admin, please rerender

ReimarBauer commented 2 months ago

@h-vetinari

Thanks for fixing this. Do we need to set a different build number? Or don't we need to update the existing package, because it was only in the description but can't be used.

I am not sure if a merge will copy over or just drop.

h-vetinari commented 2 months ago

This was mostly me testing whether the build still passes if we remove the default channels. We don't have to merge this PR, though if you'd like to we can (and then it's safer to bump the build number indeed). Otherwise you can just pick up https://github.com/conda-forge/mss-feedstock/pull/179/commits/56dde22ce6515496521df5431abe6d97d0792f51 whenever you do the next PR