Add missing architecture-dependent binaries to package

conda-forge / mssql-scripter-feedstock

A conda-smithy repository for mssql-scripter.

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

Add missing architecture-dependent binaries to package #7

Closed borchero closed 1 year ago

borchero commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [10, 11, 12, 13]

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

borchero commented 1 year ago

@conda-forge-admin, please rerender

borchero commented 1 year ago

@conda-forge-admin, please rerender

maresb commented 1 year ago

What's the motivation for this? Installing from wheels is quite non-standard for conda-forge.

borchero commented 1 year ago

@maresb I don't know if you've used this conda package recently but it does not actually work. Quite a few binaries are missing that are only available in the wheels that can be found on PyPi.

You can easily deduce that from the size of the packages: the wheel on PyPi is >30 MiB while the conda package is 21 kB.

In general, I'm happy to not use wheels but I think this is the easiest way to fix the package...

maresb commented 1 year ago

Hmm, I haven't used it recently. I'm sorry to hear that it's broken.

The conda-forge philosophy is that everything should be compiled on the conda-forge infrastructure. Are the missing libraries open-source?

borchero commented 1 year ago

The conda-forge philosophy is that everything should be compiled on the conda-forge infrastructure. Are the missing libraries open-source?

I'm checking ... I realized that downloading the wheel is also very undesirable because it enforces a useless dependency on enum34 because the wheel was created with an ancient version of Python apparently 😬

UPDATE: looks good, I will properly build the conda package here

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

borchero commented 1 year ago

@conda-forge-admin, please rerender

borchero commented 1 year ago

@conda-forge-admin, please rerender