revert to metis 5.1.0 - Githubissues

conda-forge / mumps-feedstock

A conda-smithy repository for mumps.

BSD 3-Clause "New" or "Revised" License

5 stars 24 forks source link

Closed akhmerov closed 8 months ago

akhmerov commented 8 months ago

Closes #106

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

akhmerov commented 8 months ago

@minrk @traversaro this seems to be fairly straightforward, and the build is passing. I've left the metis patch in the repo for future use.

minrk commented 8 months ago

This will work. Once https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5397 propagates, specifying the version in meta.yaml shouldn't be necessary and the updated pin should be applied by a rerender.

akhmerov commented 8 months ago

Ah, does it mean I should remove the pin?

minrk commented 8 months ago

Depends on if you want to wait an hour or two for conda-forge-pinning to propagate :)

minrk commented 8 months ago

Actually, looks like it's ready now. Removing the pin and rerendering applies the 5.1.0 pin

minrk commented 8 months ago

When this lands, do folks think we're ready to start the migrator for mumps itself? https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5274