search

conda-forge / mumps-feedstock

A conda-smithy repository for mumps.
BSD 3-Clause "New" or "Revised" License
5 stars 23 forks source link

build linux/mac with openmp #121

Closed minrk closed 1 month ago

minrk commented 2 months ago

not Windows (#61), only because I don't know how to do that. It's unclear if Windows should use intel-openmp or llvm-openmp, and whether we can just use FindOpenMP in cmake and it will Just Work.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

traversaro commented 2 months ago

I am probably just missing something about the mumps structure and build system, but does it make sense to enable openmp also for mumps_seq or it should be enabled just for mumps_par?

minrk commented 2 months ago

par == multiprocess with mpi, seq == single process. openmp threads are within each process, so are appropriate in both (omp threads are slightly less likely to be used with mpi, where each process is often allocated one cpu core, so adding threads on top can result in more total threads than cores).

traversaro commented 2 months ago

par == multiprocess with mpi, seq == single process. openmp threads are within each process, so are appropriate in both (omp threads are slightly less likely to be used with mpi, where each process is often allocated only one thread).

Thanks, that is much more clear now!

minrk commented 2 months ago

I've done some reading, and openmp on windows appears to be a hornet's nest, so I think we should wait to tackle that:

It seems like this might start to get better soon with the imminent flang update in #119: