enable OSX arm64 - attempt 2

conda-forge / mumps-feedstock

A conda-smithy repository for mumps.

BSD 3-Clause "New" or "Revised" License

5 stars 23 forks source link

enable OSX arm64 - attempt 2 #75

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 2 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 2 years ago

Not sure what's going on for the Win build - nothing has changed there:

CMake Error at CMakeLists.txt:19 (project):
  No CMAKE_Fortran_COMPILER could be found.

  Tell CMake where to find the compiler by setting either the environment
  variable "FC" or the CMake cache entry CMAKE_Fortran_COMPILER to the full
  path to the compiler, or to the compiler name if it is in the PATH.

Tobias-Fischer commented 2 years ago

All builds except for Windows now succeed.

@conda-forge/help-osx-arm64 @conda-forge/mumps @traversaro - could you please have a look?

traversaro commented 2 years ago

Random guess: set FC=flang?

traversaro commented 2 years ago

Actually I installed locally and even if I installed the same version used in https://github.com/conda-forge/mumps-feedstock/runs/3253545563 (last successful build) I do not have any flang.exe installed, just flang1.exe and flang2.exe, not sure why.

traversaro commented 2 years ago

Actually I installed locally and even if I installed the same version used in https://github.com/conda-forge/mumps-feedstock/runs/3253545563 (last successful build) I do not have any flang.exe installed, just flang1.exe and flang2.exe, not sure why.

We could try to pass flang1 or flang2 as compiled, but it is a shot in the dark. Perhaps @conda-forge/flang may know something more.

isuruf commented 2 years ago

https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/226 should fix it

traversaro commented 2 years ago

conda-forge/conda-forge-repodata-patches-feedstock#226 should fix it

Great, thanks!

traversaro commented 2 years ago

Actually I installed locally and even if I installed the same version used in https://github.com/conda-forge/mumps-feedstock/runs/3253545563 (last successful build) I do not have any flang.exe installed, just flang1.exe and flang2.exe, not sure why.

An explanation is given in https://github.com/mamba-org/mamba/issues/897#issuecomment-1037456465 . TL;DR: It is related to a difference in how conda and mamba resolve packages, and now mamba is used by default.

Tobias-Fischer commented 2 years ago

@conda-forge/mumps - this is ready for review. The windows build fail should be resolved by a restart of the CI in a few hours.

Tobias-Fischer commented 2 years ago

Thanks for the hints @traversaro @isuruf !

traversaro commented 2 years ago

@conda-forge-admin, please restart ci

traversaro commented 2 years ago

@conda-forge/mumps - this is ready for review. The windows build fail should be resolved by a restart of the CI in a few hours.

The Windows build is now ok.

dalcinl commented 2 years ago

@Tobias-Fischer @traversaro Should I merge?

traversaro commented 2 years ago

@Tobias-Fischer @traversaro Should I merge?

Yes, thanks!

Tobias-Fischer commented 2 years ago

Yes please :)

isuruf commented 2 years ago

@conda-forge-admin, rerender

dalcinl commented 2 years ago

@isuruf Please click the merge button if you are done. Maybe you should also close #73?

Tobias-Fischer commented 2 years ago

I think we can merge this @dalcinl