napari-aicsimageio v0.7.0

conda-forge / napari-aicsimageio-feedstock

A conda-smithy repository for napari-aicsimageio.

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

napari-aicsimageio v0.7.0 #7

Closed tlambert03 closed 2 years ago

tlambert03 commented 2 years ago

closes #6

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

tlambert03 commented 2 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

tlambert03 commented 2 years ago

ok, should be good to go assuming tests pass

tlambert03 commented 2 years ago

i removed pip check here... it's was failing because aicslibczi isn't on conda-forge, but we don't need it here. it's also failing to detect the version of resource-backed-dask-array... that one I can't figure out. all the pypi metadata is correct, and when I install from pypi, it gets the dist info version correct. but for some reason if the file on conda forge https://anaconda.org/conda-forge/resource_backed_dask_array/files has the wrong version in the dist-info inside of the tar gz. I'd need @jaimergp to tell me what's going on with that one