Various fixes - Githubissues

conda-forge / nccl-feedstock

A conda-smithy repository for nccl.

BSD 3-Clause "New" or "Revised" License

4 stars 16 forks source link

Various fixes #109

Closed danpetry closed 3 weeks ago

danpetry commented 5 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Use conda's ar rather than the system one
Various fixes to the build scripts:
- CUDARTLIB is cudart_static by default, so this isn't needed
- nvcc is /bin/nvcc by default, so no need for patch or setting it explicitly
- Handing CUDA_HOME to make via an environment variable works; using eval and make args doesn't.
- other environment variables need to be tested for effectiveness having been changed from args.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. For further details, please see https://github.com/conda-forge/conda-forge.github.io/issues/2102.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

danpetry commented 5 months ago

@conda-forge-admin, please rerender

jakirkham commented 5 months ago

Thanks Daniel! 🙏

These seem like good improvements. Asked a few questions above

danpetry commented 5 months ago

Everything looks ok re cross-compilation

danpetry commented 1 month ago

@conda-forge-admin, please re-render

danpetry commented 1 month ago

@jakirkham any thoughts on this..?

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

danpetry commented 1 month ago

@conda-forge-admin, please re-render

danpetry commented 1 month ago

@jakirkham ping

conda-forge-admin commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

danpetry commented 1 month ago

@conda-forge-admin, please re-render

conda-forge-admin commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

danpetry commented 1 month ago

Comments addressed

danpetry commented 4 weeks ago

@bdice are the changes ok for you?

jakirkham commented 3 weeks ago

Thanks all! 🙏

danpetry commented 3 weeks ago

nice, no worries, it's helpful to upstream some of the changes we made to the defaults recipes. On our side too, because it makes pulling updates cleaner.