MNT: Try removing some library pins

conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.

BSD 3-Clause "New" or "Revised" License

3 stars 25 forks source link

MNT: Try removing some library pins #104

Closed dopplershift closed 4 years ago

dopplershift commented 4 years ago

These (well mkl and openmp) conflict with those for the current Windows scipy package (on defaults), making it impossible to install this package on Windows alongside it (1.5.3 works). These aren't even dependencies of this library, but artifacts of libnetcdf/mpi/openmp.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

dopplershift commented 4 years ago

So removing those pins did not impact the build of this at all for the configs that these pins solved before...and now a new set of configs fail. Well that's...interesting. 🙄

xylar commented 4 years ago

@conda-forge-admin, please rerender

dopplershift commented 4 years ago

@conda-forge-admin, please restart ci

dopplershift commented 4 years ago

@conda-forge-admin, please restart ci

dopplershift commented 4 years ago

🎉 @conda-forge/netcdf4 it passed! Would love a merge while it still does... 😉