Add mpich-mpicc as dependency for mpich builds

conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.

BSD 3-Clause "New" or "Revised" License

3 stars 25 forks source link

Add mpich-mpicc as dependency for mpich builds #113

Closed xylar closed 3 years ago

xylar commented 3 years ago

Update the license to match the upstream repository.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

xylar commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 3 years ago

@conda-forge-admin, please rerender

xylar commented 3 years ago

@conda-forge-admin, please rerender

ocefpaf commented 3 years ago

LGTM, merge?

xylar commented 3 years ago

@ocefpaf, I'd still like to get clarity on whether this is the preferred solution to the problem we had in #112. Let's hold off just a bit.

xylar commented 3 years ago

I didn't get the feedback I was hoping for but I think we can go ahead with this solution for now and implement a preferred solution if there is one later on.