search

conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.
BSD 3-Clause "New" or "Revised" License
3 stars 25 forks source link

MNT: Update build/test environment name #19

Closed conda-forge-admin closed 8 years ago

conda-forge-admin commented 8 years ago

Hi! This is the friendly conda-forge-admin automated user.

I've updated this feedstock to replace the hard-coded build/test environment name with the more general PREFIX environment variable. This will enable the recipe to build with both conda-build 1.* and 2.*

If the changes look good, then please go ahead and merge this PR. If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).

Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package. Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.

Thanks!

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pelson commented 8 years ago

Ping @dkillick who has been helping me to do this script.

pelson commented 8 years ago

Even though the tests are failing, the problem is our use of conda-build 1.x:

# If you want to upload this package to anaconda.org later, type:
#
# $ anaconda upload /feedstock_root/build_artefacts/linux-64/netcdf4-1.2.4-np110py27_2.tar.bz2
#
# To have conda build upload to anaconda.org automatically, use
# $ conda config --set anaconda_upload yes

Using Anaconda API: https://api.anaconda.org
Traceback (most recent call last):
  File "/feedstock_root/ci_support/upload_or_check_non_existence.py", line 124, in <module>
    main()
  File "/feedstock_root/ci_support/upload_or_check_non_existence.py", line 104, in main
    exists = built_distribution_already_exists(cli, meta, owner)
  File "/feedstock_root/ci_support/upload_or_check_non_existence.py", line 24, in built_distribution_already_exists
    fname = bldpkg_path(meta)
TypeError: bldpkg_path() missing 1 required positional argument: 'config'

./ci_support/run_docker_build.sh returned exit code 1

What I'm going to do therefore is trade this PR (i.e. merge it) for a rerendering PR, which should now pass.

pelson commented 8 years ago

The PR that has been created is #20.