search

conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.
BSD 3-Clause "New" or "Revised" License
3 stars 25 forks source link

Sane numpy #36

Closed kain88-de closed 7 years ago

kain88-de commented 7 years ago

sane numpy config. Add python 3.4 to build matrix

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 7 years ago

@kain88-de we'll need latest libnetcdf and its dependencies for vc10 to get Python 3.4 here correctly. I'll look into it.

kain88-de commented 7 years ago

How is that related?

ocefpaf commented 7 years ago

Python 3.4 uses vc 10, see https://conda-forge.org/docs/buildwin.html#vc-features, and we need version of the updated dependencies compiled with vc 10. We can probably find the old ones in the channel, but I highly recommend to use the latest versions of the dependencies.

PS: the failure you are seeing though is unrelated. It is because AppVeyor no longer has miniconda for Python 3.4. You will need to manually change that like this and let miniconda download Python 3.4 at build time.

ocefpaf commented 7 years ago

Done in #37