Rebuild netCDF4 after bug fix in libnetcdf build

conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.

BSD 3-Clause "New" or "Revised" License

3 stars 25 forks source link

Rebuild netCDF4 after bug fix in libnetcdf build #68

Closed xylar closed 5 years ago

xylar commented 5 years ago

The fix to libnetcdf should make nc-config produce a correct path, which is expected to change the build of netCDF4. In particular, netCDF4 is expected to notice CDF5 support with this fix.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

closes #67

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

xylar commented 5 years ago

I tried to re-render for you, but it looks like there was nothing to do.

That's what I thought, but I was just doing this to be on the safe side...

xylar commented 5 years ago

I ran a local test with the circleci docker image. I then installed the local netCDF4 package and can confirm that this seems to fix #67 and https://github.com/MPAS-Dev/MPAS-Analysis/issues/459.

$ conda create -n test --use-local -c conda-forge netcdf4
...
$ conda activate test
$ python -c "import netCDF4; print(netCDF4.__has_cdf5_format__)"
1

ocefpaf commented 5 years ago

@xylar given you interest in netCDF4 (and libnetcdf) and your experience with conda-forge would you consider adding yourself as a maintainer here too? This PR is a good candidate for a self-merge :wink:

xylar commented 5 years ago

@ocefpaf, good point. I debated about adding myself as a maintainer and you've talked me into it. Please go ahead and merge when you like. No need to wait for CI to re-run after the latest commit.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 5 years ago

@ocefpaf, good point. I debated about adding myself as a maintainer and you've talked me into it. Please go ahead and merge when you like. No need to wait for CI to re-run after the latest commit.

Thanks!!