conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.
BSD 3-Clause "New" or "Revised" License
3 stars 25 forks source link

Rebuild with latest libnetcdf build and hdf5 1.10.2 #69

Closed xylar closed 5 years ago

xylar commented 5 years ago

Checklist

A recent fix to the libnetcdf build (https://github.com/conda-forge/libnetcdf-feedstock/pull/59) corrected the paths displayed by nc-config and allowed netcdf4 to recognize cdf-5 format files once again. #68 brought in this fix along with hdf5 1.10.3. However, many conda-forge packages (notably h5py) are not yet built with hdf5 1.10.3. So it will be useful to have a build with the nc-config fix and with hdf5 1.10.2.

xylar commented 5 years ago

Note: I am merging this to a dummy branch (builds_with_hdf5_1.10.2) so as not to update master with some one-off changes.

ocefpaf commented 5 years ago

We may need to restart the CIs b/c GitHub is not working properly today :-/

xylar commented 5 years ago

Yeah, GitHub seems to be a real mess today. Let me know if there's anything I can do to help. Thanks for merging.

ocefpaf commented 5 years ago

Yeah, GitHub seems to be a real mess today. Let me know if there's anything I can do to help. Thanks for merging.

We can send an empty commit to that branch when things stabilize. I just tried that but I was unable to get the CIs started.

xylar commented 5 years ago

@ocefpaf, most CI went through okay but one AppVeyor job failed. I don't think that's likely to be a big deal because there's already a Windows version of the current netcdf4 with hdf5 1.10.2, and the build issue didn't affect Windows. But you could try to get that last job to run if you like.