Bump build number - Githubissues

conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.

BSD 3-Clause "New" or "Revised" License

3 stars 25 forks source link

Bump build number #72

Closed djhoese closed 5 years ago

djhoese commented 5 years ago

Need to pick up HDF5 1.10.4 in build process. See https://github.com/conda-forge/h5py-feedstock/pull/46 and https://github.com/conda-forge/gdal-feedstock/pull/243 for reference. Bottom line: can't install new/fixed gdal in a Windows environment if netcdf4 and/or h5py are installed since they are built with old HDF5.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

djhoese commented 5 years ago

@conda-forge-admin, please rerender

djhoese commented 5 years ago

Windows Python 2.7 failed with:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform win-64: {'libnetcdf=4.6', 'hdf5=1.10.4', 'python=2.7'}

Ideas? Does the libnetcdf requirement need to be relaxed?

Edit: I'm not really sure what is going on here. What other dependency could be causing this? The libnetcdf and hdf5 versions aren't hardcoded.

ocefpaf commented 5 years ago

Ideas? Does the libnetcdf requirement need to be relaxed?

Not really. vc9 should be abandoned. What is happening is that latest libnetcdf, built with latest hdf5, won't compile with the old vc9 for legacy Python on Windows.

djhoese commented 5 years ago

@ocefpaf Yep, @kmuehlbauer just mentioned that on the issue I made for libnetcdf (see https://github.com/conda-forge/libnetcdf-feedstock/issues/65).

ocefpaf commented 5 years ago

@conda-forge-admin, please rerender

djhoese commented 5 years ago

@ocefpaf FYI, skipping python 2.7 on Windows for this package will mean library loading issues for environments that have netcdf and gdal installed in the same environment unless all of the gdal packages that aren't specifically tagged as vc9 are marked as broken.

ocefpaf commented 5 years ago

@ocefpaf FYI, skipping python 2.7 on Windows for this package will mean library loading issues for environments that have netcdf and gdal installed in the same environment unless all of the gdal packages that aren't specifically tagged as vc9 are marked as broken.

We may have badly pinning packages but that should not be a problem as long as I identify them. Conda-build 3 adds the proper metadata and conda should be able to install the old version that are properly pinned.

djhoese commented 5 years ago

Thanks. I'll try to let you know if I run in to any more issues. We'll see what happens after this is PR is merged. 🤞

djhoese commented 5 years ago

Restarted travis job that seems like it got stuck.

djhoese commented 5 years ago

@ocefpaf I think this is ready for merge.

ocefpaf commented 5 years ago

Thanks @djhoese!