conda-forge / netcdf4-feedstock

A conda-smithy repository for netcdf4.
BSD 3-Clause "New" or "Revised" License
3 stars 25 forks source link

nompi build can use MPI or no-MPI variants at runtime #99

Closed xylar closed 4 years ago

xylar commented 4 years ago

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

xylar commented 4 years ago

In some of my testing where I want parallel versions of libnetcdf and hdf5 but I don't need the parallel version of netcdf4, I'm running into trouble when trying to run python code without mpirun even when it is ostensibly serial code. These changes should allow me to explicitly say that I want the MPI versions of libnetcdf and hdf5 without having to also pick up the MPI version of netcdf4, e.g.:

conda create -y -n test python=3.7 "libnetccf=*=mpi_mpich_*" "hdf5=*=mpi_mpich_*" \
   "netcdf=*=nompi_*"
xylar commented 4 years ago

@conda-forge-admin, please rerender

xylar commented 4 years ago

I will do some local testing of these changes. @conda-forge/netcdf4, any objections to them? If not, I'll merge as soon as I'm done with my local testing.

xylar commented 4 years ago

This worked great in my local tests. I was able to create a conda environment with mpich variants of libnetcdf, etc. but the nompi version of netcdf4 and the difficulties I'd been having with netcdf4 went away!

@conda-forge/netcdf4, any objections to me merging this? If I don't hear anything by this time tomorrow, I'm going to go ahead.

ocefpaf commented 4 years ago

Thanks for fixing this @xylar!