Open jcfr opened 5 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
This PR simply updates the version of ninja by downloading the latest version, it does NOT downnload the source from a different repository like what was done in https://github.com/conda-forge/ninja-feedstock/pull/12
It is not 1.9.0 version. It would be much easier for everyone if the upstream just release a new version. If they cannot (e.g. they feel that the current changes are not polished enough, yet), it does not make sense for us to package this early version as a stable release replacement. The only thing we can do about it is to release it as a dev
version, but I don't remember all the incantations.
The only thing we can do about it is to release it as a dev version
Makes sense. Is it a matter on appending the .dev
suffix ?
It needs to go to a separate branch of the feedstock and it may also require some configuration tuning. I will only have bandwidth to look into it later next week.
Sounds good. If you could point me toward some documentation, I could help as well. In the mean time, thanks again for your input and help.
That is the whole point that I need to find the documentation or an example to follow :)
Following a suggestion of @msarahan , looking at the pre-release package for python 3.8 seems like a good approach. See https://github.com/conda-forge/python-feedstock/blob/pre-3.8/recipe/meta.yaml
We now need to choose a release number for this pre-release, for example pre-1.10.0
(current version if 1.9.0
), I will send an email to the ninja mailing list to know what version number they anticipate for their next release.
this is released now, I guess?
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)List of changes since v1.9.0: