conda-forge / ninja-feedstock

A conda-smithy repository for ninja.
BSD 3-Clause "New" or "Revised" License
2 stars 18 forks source link

Add stub package python-ninja #32

Closed awvwgk closed 1 year ago

awvwgk commented 1 year ago

Checklist

Closes #26 Closes https://github.com/conda-forge/staged-recipes/pull/19098

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

henryiii commented 1 year ago

I still believe this is not the correct fix. This won't fix other non-conda packaging ecosystems. It should be fixed upstream in the (two known) packages that misuse it, then patched there until a new version is out. If there is a python-ninja, it should be a repacking of the actual python ninja package. If someone actually does need the Python package with jobserver support, they should be able to require it. These packages do not, but just have a faulty discovery / usage of ninja only from the package.

Trying to hack around the problem is just going to cause problems later. You can't delete the fake package once it's released.